Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump actions/setup-go from 3.0.0 to 3.2.0 #132

Merged
merged 1 commit into from May 30, 2022

Conversation

drpaneas
Copy link
Contributor

@drpaneas drpaneas commented May 27, 2022

Description:

This allows us to hardcode a Go supported version for the project in a file, so then the Go GitHub Action can read that file and run the CI based on this specific Go version. I am wondering if OpenShift CI has something similar (just tagging @samyak-jn to me him aware of this).

The rest of the changelog:

Bumps actions/setup-go from 3.0.0 to 3.2.0.

Release notes

Sourced from actions/setup-go's releases.

Support for caching dependency files and compiler's build outputs

This release introduces support for caching dependency files and compiler's build outputs #228. For that action uses @​toolkit/cache library under the hood that in turn allows getting rid of configuring @​actions/cache action separately and simplifies the whole workflow.

Such input parameters as cache and cache-dependency-path were added. The cache input is optional, and caching is turned off by default, cache-dependency-path is used to specify the path to a dependency file - go.sum.

Examples of use-cases:

  • cache input only:
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
  with:
    go-version: '18'
    cache: true
  • cache along with cache-dependency-path:
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
  with:
    go-version: '18'
    cache: true
    cache-dependency-path: subdir/go.sum

Add go-version-file input

Adding Go version file support

In scope of this release we add the go-version-file input. The new input (go-version-file) provides functionality to specify the path to the file containing Go version with such behaviour:

  • If the file does not exist the action will throw an error.
  • If you specify both go-version and go-version-file inputs, the action will use value from the go-version input and throw the following warning: Both go-version and go-version-file inputs are specified, only go-version will be used.
  • For now the action supports .go-version and go.mod files.
steps:
 - uses: actions/checkout@v3
 - uses: actions/setup-go@v3
   with:
     go-version-file: 'path/to/go.mod'
 - run: go version

Besides, the following pull requests included in this release:

... (truncated)

Commits
  • b22fbbc Implementation of caching functionality for setup-go action (#228)
  • fcdc436 Update @​zeit/ncc to @​vercel/ncc (#229)
  • 265edc1 Add go-version-file option (#62)
  • 193b404 Successfully set up (#231)
  • 56a61c9 Create ADR for integrating cache functionality to setup-go action (#217)
  • b46db95 Merge pull request #222 from vsafonkin/v-vsafonkin/add-readme-note
  • 3332358 Add note about go building
  • 46eabca Merge pull request #221 from vsafonkin/v-vsafonkin/fix-gopath-condition
  • 0794822 Rename CONDUCT.md and change email inside (#218)
  • ad70bef Fix condition for old go versions
  • Additional commits viewable in compare view

Link to JIRA Story (if applicable):

No JIRA

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #132 (ee6f8fe) into main (f287ecc) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   37.23%   37.25%   +0.01%     
==========================================
  Files          74       74              
  Lines       10333    10333              
==========================================
+ Hits         3848     3850       +2     
+ Misses       5869     5867       -2     
  Partials      616      616              
Impacted Files Coverage Δ
...p/application_event_loop/application_event_loop.go 40.55% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f287ecc...ee6f8fe. Read the comment docs.

@jgwest jgwest self-requested a review May 30, 2022 12:46
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label May 30, 2022
@jgwest jgwest merged commit 797d7be into redhat-appstudio:main May 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: drpaneas, jgwest

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants