Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
At the moment
setup-go
action has logic to create directory and add it in the runner PATH if thego env GOPATH
command has path in output. There is no path in command output for go version < 1.7 but this command returns single byte so the condition to checkgo env GOPATH
output is true for any go versions.For example
go 1.5:
go 1.18:
This logic caused an error but it did not interrupt action on node 12 (action v2 version):
Successful run with error for go 1.5 on action v2 version: https://github.com/vsafonkin/test-repo/runs/6054892779?check_suite_focus=true#logs
After action update to node 16 (action v3 version) this error breaks the action execution.
Fixed the condition for
go env PATH
output.Test run with go 1.18: https://github.com/vsafonkin/test-repo/actions/runs/2180363887
Test run with go 1.5: https://github.com/vsafonkin/test-repo/actions/runs/2180366207
Related issue:
#216
Check list: