Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Skip yield return on AddClosureReturnTypeRector #3227

Merged
merged 1 commit into from Dec 20, 2022
Merged

[TypeDeclaration] Skip yield return on AddClosureReturnTypeRector #3227

merged 1 commit into from Dec 20, 2022

Conversation

samsonasik
Copy link
Member

skip yield return on AddClosureReturnTypeRector, use AddReturnTypeDeclarationFromYieldsRector to cover it.

Fixes rectorphp/rector#7673

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thanks 👍

@TomasVotruba TomasVotruba merged commit 25ccfe1 into main Dec 20, 2022
@TomasVotruba TomasVotruba deleted the skip-yield-add-closure branch December 20, 2022 17:41
@samsonasik samsonasik mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @TomasVotruba