Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Skip optional yield on AddReturnTypeDeclarationFromYieldsRector #3228

Merged
merged 4 commits into from Dec 20, 2022
Merged

[TypeDeclaration] Skip optional yield on AddReturnTypeDeclarationFromYieldsRector #3228

merged 4 commits into from Dec 20, 2022

Conversation

samsonasik
Copy link
Member

Continue of #3227

The following code should be skipped:

$func = function ()  {
    if (rand(0, 1)) {
        yield 1;
    }
};

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik changed the title [TypeDeclration] Skip optional yield on AddReturnTypeDeclarationFromYieldsRector [TypeDeclaration] Skip optional yield on AddReturnTypeDeclarationFromYieldsRector Dec 20, 2022
@samsonasik samsonasik merged commit cf2805b into main Dec 20, 2022
@samsonasik samsonasik deleted the skip-optional-yield branch December 20, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @TomasVotruba @actions-user