Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Move from EndBug/add-and-commit to stefanzweifel/git-auto-commit-action #3168

Closed
wants to merge 3 commits into from
Closed

[CI] Move from EndBug/add-and-commit to stefanzweifel/git-auto-commit-action #3168

wants to merge 3 commits into from

Conversation

samsonasik
Copy link
Member

Ref rectorphp/rector#7579

If it works, the reusable-workflows/.github/workflows need update as well.

@samsonasik
Copy link
Member Author

Lets' test add unusedPrivateProperty to make rectify

@samsonasik
Copy link
Member Author

samsonasik commented Dec 7, 2022 •
edited

@TomasVotruba not sure why the rectify show pending when add new github action:

 rector (config utils) Expected — Waiting for status to be reported

could you verify if new github workfow need manual verify? Thank you.

@TomasVotruba
Copy link
Member

We can stick with current action for commits, as it works well. Warning is ok 👍

@samsonasik samsonasik deleted the move-end-bug-to-git-auto-commit branch December 11, 2022 16:40
@samsonasik samsonasik mentioned this pull request Feb 28, 2023
Merged
@samsonasik samsonasik restored the move-end-bug-to-git-auto-commit branch February 28, 2023 16:33
@samsonasik samsonasik mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @TomasVotruba