[DX] Add "setup-ci" command to ease integration to CI #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
samsonasik
reviewed
Feb 28, 2023
| - | ||
| # commit only to core contributors who have repository access | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| uses: EndBug/add-and-commit@v7.5.0 |
There was a problem hiding this comment.
this still using set-output that will no longer work after next May https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
I was creating PR to replace it:
but cause pending workflow (probably need to be re-activated for new workflow), see
There was a problem hiding this comment.
@samsonasik Could re-open the PR and change part of code to make Rector apply? Let's see if works now :)
There was a problem hiding this comment.
@TomasVotruba Ok, re-open, the private $unusedPrivateProperty; is on purpose to verify Rector apply
TomasVotruba
force-pushed
the
tv-helper-ci
branch
from
0ff8fba
to
259d716
Compare
TomasVotruba
force-pushed
the
tv-helper-ci
branch
from
259d716
to
5a0d656
Compare
TomasVotruba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.