Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forward slash as hotkey for search UI #31

Merged
merged 1 commit into from Jul 17, 2019
Merged

Add forward slash as hotkey for search UI #31

merged 1 commit into from Jul 17, 2019

Conversation

dojutsu-user
Copy link
Member

No description provided.

@dojutsu-user dojutsu-user added this to In progress in In-doc search UI via automation Jul 17, 2019
@dojutsu-user
Copy link
Member Author

I have already added this in doc in PR #30

ericholscher
ericholscher approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericholscher ericholscher merged commit ba93b77 into master Jul 17, 2019
@dojutsu-user dojutsu-user deleted the hotkey-for-search-modal branch July 17, 2019 19:30
@dojutsu-user dojutsu-user moved this from In progress to Done in In-doc search UI Jul 20, 2019
@humitos humitos mentioned this pull request Mar 15, 2021
Closed
@mgeier
Copy link

mgeier commented Jan 18, 2022

For the record: this doesn't seem to work on keyboards where the Shift button has to be pressed to get the forward slash.

However, if and when sphinx-doc/sphinx#9337 gets merged, this should magically start working.

@mgeier mgeier mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@davidfischer davidfischer Awaiting requested review from davidfischer

Assignees
No one assigned
Labels
None yet
Projects
No open projects
In-doc search UI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dojutsu-user @mgeier @ericholscher