Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CTRL+f to open the search box? #87

Closed
humitos opened this issue Mar 15, 2021 · 5 comments
Closed

Use CTRL+f to open the search box? #87

humitos opened this issue Mar 15, 2021 · 5 comments
Labels
Feature New feature Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Mar 15, 2021

In #31 we added / as a hotfix to open the search box which is good.

Today I found that Stripe docs goes a step further here and uses CTRL+f which I thought immediately it was a bad decision because "I want to use just the regular search of my browser", but then I saw it says that you can hit CTRL+f again to switch to the default search feature 💯

Screenshot_2021-03-15_10-35-25

NOTE the message and checkbox at the bottom right

You can try it by yourself at https://stripe.com/docs/api/events/types

@humitos humitos added the Feature New feature label Mar 15, 2021
@stsewd stsewd added the Needed: design decision A core team decision is required label Mar 15, 2021
@astrojuanlu
Copy link
Contributor

I'm generally very annoyed when a website intercepts Ctrl+F or any other usual keyboard shortcut like Ctrl+Tab. I wonder if there's some user research available out there.

@stsewd
Copy link
Member

stsewd commented Oct 6, 2021

I'm generally very annoyed when a website intercepts Ctrl+F or any other usual keyboard shortcut like Ctrl+Tab. I wonder if there's some user research available out there.

same, was just reading the stripe docs, and hijacking my ctrl-f is annoying, didn't even read the "pressing ctrl-f again" suggestion, I just assumed it wasn't possible to have my firefox's search back...

@astrojuanlu
Copy link
Contributor

https://twitter.com/killedbygoogle/status/1465196733567320068

Can we close this as won't-fix? 😄

@choldgraf
Copy link

choldgraf commented Jul 11, 2022

In my opinion, this could be a decision that individual themes make, rather than this extension. For example, in the PyData theme we use ctrl + k to open up the search bar, and it'd be nice if we could automatically hook into this extension instead if it were activated.

So you could document how other themes could use this extension + activate it via a keyboard shortcut as they wish.

@humitos
Copy link
Member Author

humitos commented Apr 11, 2023

Moved the conversation to readthedocs/addons#43

@humitos humitos closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

4 participants