Forward compatibility with PHPUnit 6 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Nov 12, 2017
|
According to reactphp/socket#132 it should be 5.7.11 as min version. |
clue
reviewed
Nov 13, 2017
|
@clue Done. Added |
clue
approved these changes
Nov 14, 2017
clue
changed the title
jsor
approved these changes
Nov 14, 2017
|
Rebased now that #244 is in |
WyriHaximus
pushed a commit
to WyriHaximus/http
that referenced
this pull request
Nov 14, 2017
Forward compatibility with PHPUnit 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the
PHPUnit\Framework\TestCasenotation instead ofPHPUnit_Framework_TestCasewhile extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.I just need to bump PHPUnit version to
^4.8.35and^5.7, that support this namespace.