Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PHPUnit version #391

Closed
wants to merge 1 commit into from
Closed

Bump PHPUnit version #391

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link

Bump PHPUnit version to ~4.8.35, to follow several changes made through Reactphp repos.

@clue
Copy link
Member

clue commented Nov 13, 2017

Thank you for filing this PR! I agree that adding support for newer PHPUnit versions makes perfect sense, much appreciated! However, this one is currently a bit unclear, what is the motivation for this change?

@carusogabriel
Copy link
Author

As I've updated PHPUnit to several Reatchphp components (socket, http, event-loop, etc), I think is nice to have everything syncronized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants