Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add testID and accessibilityLabel to DrawerItem #11168

Merged
merged 4 commits into from Feb 12, 2023
Merged

feat: add testID and accessibilityLabel to DrawerItem #11168

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b88dd37
feat: add testID and accessibilityLabel to DrawerItem
andrewtremblay Jan 20, 2023
20970a8
Merge branch 'main' into feat/add-testids-to-drawer
andrewtremblay Jan 31, 2023
b19a2c5
feat: add testID and accessibilityLabel to DrawerItem (addressing PR …
andrewtremblay Feb 6, 2023
0ef4a2d
Merge branch 'main' into feat/add-testids-to-drawer
satya164 Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/drawer/src/views/DrawerItem.tsx
View file
Open in desktop
Expand Up @@ -81,6 +81,15 @@ type Props = {
* Whether label font should scale to respect Text Size accessibility settings.
*/
allowFontScaling?: boolean;

/**
* Accessibility label for drawer item.
*/
accessibilityLabel?: string;
/**
* ID to locate this drawer item in tests.
*/
testID?: string;
};

const LinkPressable = ({
Expand Down Expand Up @@ -160,6 +169,8 @@ export default function DrawerItem(props: Props) {
onPress,
pressColor,
pressOpacity,
testID,
accessibilityLabel,
...rest
} = props;

Expand All @@ -178,8 +189,10 @@ export default function DrawerItem(props: Props) {
style={[styles.container, { borderRadius, backgroundColor }, style]}
>
<LinkPressable
testID={testID}
onPress={onPress}
style={[styles.wrapper, { borderRadius }]}
accessibilityLabel={accessibilityLabel}
accessibilityRole="button"
accessibilityState={{ selected: focused }}
pressColor={pressColor}
Expand Down