New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add testID and accessibilityLabel to DrawerItem #11168
feat: add testID and accessibilityLabel to DrawerItem #11168
Conversation
Hey andrewtremblay! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can you remove the labeltestID
? Ideally users would use the test tool's methods to check the contained text.
Also remove the comments about LinkPressable
since it's not relevant to users since it's an implementation detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportBase: 74.09% // Head: 74.09% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #11168 +/- ##
=======================================
Coverage 74.09% 74.09%
=======================================
Files 176 176
Lines 5598 5598
Branches 2193 2193
=======================================
Hits 4148 4148
Misses 1401 1401
Partials 49 49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Added support for testIDs for the tappable DrawerItem and the DrawerItem label
Addresses #7492 and #8906
This was attempted before with #11009 but that PR was closed due to an update in the main branch.