Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum node version. #108

Closed
wtgtybhertgeghgtwtg opened this issue Dec 11, 2016 · 6 comments
Closed

Bump minimum node version. #108

wtgtybhertgeghgtwtg opened this issue Dec 11, 2016 · 6 comments

Comments

@wtgtybhertgeghgtwtg
Copy link

If you bump the minimum node version to at least 4.0.0, you can drop the dependency on os-tmpdir. I can write a PR for this if you would like.

@silkentrance
Copy link
Collaborator

silkentrance commented Dec 13, 2016

I for myself would be glad to drop support for node versions older than 4.0.0. However, I do not know if there are people out there still using it with node versions <4.0.0. Perhaps @raszi can direct us.

In any way, getting rid of older node versions is definitely worth a major version bump, say 1.0.0? #75

@wtgtybhertgeghgtwtg
Copy link
Author

Support for node<4.0.0 has been dropped. Will this be considered?

@silkentrance
Copy link
Collaborator

minimum node version has been bumped to >=0.10.0

This was referenced Nov 29, 2017
@silkentrance
Copy link
Collaborator

silkentrance commented Dec 1, 2017

Dropping support for node versions < 4.0.0 allows us to use os.tmpdir().

Deprecated: This is not needed anymore. require('os').tmpdir() in Node.js 4 and up is good.

@silkentrance
Copy link
Collaborator

Currently, we only build for and test against node >=6.

@silkentrance
Copy link
Collaborator

Since we no longer support node <6, I am closing this as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants