Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os-tmpdir was deprecated #132

Closed
silkentrance opened this issue Jul 4, 2017 · 3 comments
Closed

os-tmpdir was deprecated #132

silkentrance opened this issue Jul 4, 2017 · 3 comments

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Jul 4, 2017

With os-tmpdir being deprecated we should integrate a replacement for it ~~~that might also provide a work around for #120.~~~

This also will fix the issue with node8+ builds now failing due to os-tmpdir no longer being available.

In addition we should take into account #108 and #75 then, dropping support for node < 4 altogether.

When dropping support for the legacy node versions, our wrapper for os.tmpdir would become a rather simple one. ~~~that will just incorporate the work around for #120.~~~

@silkentrance
Copy link
Collaborator Author

The test builds for node8+ seem to be working again. Needs further investigation.

@silkentrance
Copy link
Collaborator Author

Dropping support for node versions < 4.0.0 allows us to use os.tmpdir().

Deprecated: This is not needed anymore. require('os').tmpdir() in Node.js 4 and up is good.

This requires #108

@silkentrance
Copy link
Collaborator Author

Redundant. Closing in favor of #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants