Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving towards 1.0.0 #158

Closed
silkentrance opened this issue Nov 28, 2017 · 10 comments
Closed

Moving towards 1.0.0 #158

silkentrance opened this issue Nov 28, 2017 · 10 comments

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Nov 28, 2017

As is requested by #75.

@raszi I am wanting this to finally reach 1.0.0 this year :D using the current code base. A switch over to typescript would be no problem as it would be transpiled to standard javascript and that would then be released. Or was that not your plan?

As of now, we have the unsupported legacy releases

  • 0.0.33 which dropped all support for node <0.8
  • 0.0.32 and below for node <0.8

and we have the

  • 0.1.0 release branch which still supports node 0.10.0+

The 0.1.0 we can use for maintenance work in case that major problems arise. The existing issues including the still open issues #129, #155, and #121 should also make it into this release. But we would not integrate new features into that "branch", if any such new features arise in the future.

See also the compatibility notice in the readme on current master.

And from 1.0.0 on I would like to drop support for all node versions < 4.0.0, so we can have #108.

And given 1.0.0 we could be moving to typescript and a gulp based build process, see #157.

What do you think? Sounds like a good plan to me.

@raszi raszi changed the title Discussion: Moving towards 1.0.0 Moving towards 1.0.0 Dec 2, 2017
@poppinlp
Copy link
Contributor

poppinlp commented Jan 31, 2018

Hi.
How this plan going? According to this report i think it's a good idea to drop support for node versions < 4.x. So is there any contribution needed? :)

@raszi
Copy link
Owner

raszi commented Jan 31, 2018

According to this document we can drop the support as soon as 04/30/2018.

@wtgtybhertgeghgtwtg
Copy link

4/30/2018 has passed. Are you going to drop os-tmpdir?

@raszi
Copy link
Owner

raszi commented May 13, 2018

Yes, we should. I'll do that as soon as I have some free time.

@Krinkle
Copy link

Krinkle commented Jan 15, 2019

Looks like os-tmpdir was already dropped in master last year. Would be great to have that change released as well, to help shrink downstream dependency graphs :)

@silkentrance
Copy link
Collaborator Author

os-tmpdir has long been dropped 😄

@Krinkle
Copy link

Krinkle commented Mar 14, 2019

@silkentrance Yeah, in master. The last release, however, appears to have been in 2017.

@markstos
Copy link

That's right. I just installed tmp from NPM and the dependency on os-tmpdir is still there.

@jarrodek
Copy link

So,
According to NodeJS docs currently versions >= 10 are the only supported versions (today it is 10, 12, and 13). So I guess support for any older version can be safely dropped as organizations are moving towards upgrading libraries to work on supported by Node platforms.

I would suggest to move the API towards Promise based APIs. Everyone now are using async functions and suddenly using callbacks is just inconvenient. I would be happy to work on the PR if the is the direction the library will move forward as I am using it in multiple projects.

@alubbe
Copy link

alubbe commented Jan 27, 2020

Just to add to the above point, the tmp-promise project would be interested in merging their promisified code to this project, if there's interest. @raszi would you be interested in a PR in that direction?
benjamingr/tmp-promise#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants