Set correct required_ruby_version when some RUBY_CC_VERSIONs are missing
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missing The required_ruby_version was set twice, although one in define_native_tasks is enough. Fixes rake-compiler#198
kou
reviewed
Jan 15, 2022
| @@ -377,9 +377,6 @@ def define_cross_platform_tasks(for_platform) | |||
| @lib_dir = "#{@lib_dir}/#{$1}" | |||
| end | |||
|
|
|||
| # Update cross compiled platform/version combinations | |||
| @ruby_versions_per_platform[for_platform] << version | |||
|
Thank you both! |
flavorjones
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
Jan 18, 2022
which contains rake-compiler/rake-compiler#199 and remove the workaround for ruby required versions
flavorjones
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
Jan 19, 2022
which contains rake-compiler/rake-compiler#199 and remove the workaround for ruby required versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
required_ruby_versionwas set twice, although one indefine_native_tasksis enough.The original commit that introduced automatic setting of
required_ruby_versionwas 0dc2350 . It detected the ruby version entirely based onRUBY_CC_VERSION. Later on there was commit 0dc2350 which introduced setting therequired_ruby_versionfor native but not cross gems and only for the active ruby versions. This made the first detection obsolete, but it wasn't deleted so far. This is fixed by this PR.Fixes #198