Skip to content

Commit

Permalink
ext(package): update to rake-compiler 1.1.8
Browse files Browse the repository at this point in the history
which contains rake-compiler/rake-compiler#199
and remove the workaround for ruby required versions
  • Loading branch information
flavorjones committed Jan 18, 2022
1 parent 7d29ec2 commit cdc1b0c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
2 changes: 1 addition & 1 deletion nokogiri.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency("minitest", "~> 5.15")
spec.add_development_dependency("minitest-reporters", "~> 1.4")
spec.add_development_dependency("rake", "~> 13.0")
spec.add_development_dependency("rake-compiler", "= 1.1.7")
spec.add_development_dependency("rake-compiler", "= 1.1.8")
spec.add_development_dependency("rake-compiler-dock", "~> 1.2")
spec.add_development_dependency("rdoc", "~> 6.3")
spec.add_development_dependency("rexical", "~> 1.0.7")
Expand Down
9 changes: 0 additions & 9 deletions rakelib/extensions.rake
Original file line number Diff line number Diff line change
Expand Up @@ -405,15 +405,6 @@ else
spec.files.reject! { |path| File.fnmatch?("gumbo-parser/**/*", path) }
spec.dependencies.reject! { |dep| dep.name == "mini_portile2" }

# I would like rake-compiler to do this, but can't quite figure it out right now
supported_rubies = CROSS_RUBIES.select { |c| spec.platform =~ c.platform }
.map { |c| Gem::Version.new(c.ver) }
.sort
spec.required_ruby_version = [
">= #{supported_rubies.first.to_s.split(".").take(2).join(".")}",
"< #{supported_rubies.last.to_s.split(".").take(2).join(".").succ}.dev",
]

# when pre-compiling a native gem, package all the C headers sitting in ext/nokogiri/include
# which were copied there in the $INSTALLFILES section of extconf.rb.
# (see scripts/test-gem-file-contents and scripts/test-gem-installation for tests)
Expand Down

0 comments on commit cdc1b0c

Please sign in to comment.