[5.x] Yarn v3 for stable webpacker 5.x gem #3098
Conversation
.github/workflows/ruby.yml
Outdated
| @@ -29,14 +29,6 @@ jobs: | |||
| gemfile: gemfiles/Gemfile-rails.6.0.x | |||
| experimental: [false] | |||
| include: | |||
| - ruby: 2.5 | |||
There was a problem hiding this comment.
Why did you remove these versions?
There was a problem hiding this comment.
@guillaumebriday Because Rails 7.0.0-alpha (edge) does not support ruby 2.5 and 2.6, only 2.7+ 馃憤
There was a problem hiding this comment.
I think so these removes can be done in other PR separately, only that change context to rails 7. What do you think about that?
There was a problem hiding this comment.
Yes I think it's should not be in this PR
There was a problem hiding this comment.
Considering that branch 5-x-stable does not receive frequent changes, and that this PR is small enough to be understood well (despite CI fixes be together with adding of Yarn v3), can we merge it? 馃嵒
There was a problem hiding this comment.
@pedrofurtado sounds like the preferred way forward is for you to pull the workflow changes out of this PR, focus it 馃挴 on just bringing yarn v3 support in for a quick merge....
There was a problem hiding this comment.
PR splitted in two: this that provides yarn 3 support, and other that fixes CI ( #3106 )
|
any chance we can get this merged and released soon? we rely on a yarn package that needs yarn 3, and so webpacker is continually complaining :( |
|
@imajes For a while, in order to not block your team on Yarn upgrading, please use this fork: # Gemfile
gem 'webpacker', github: 'pedrofurtado/webpacker', branch: 'v5.4.0-with-yarnv3'
# package.json
{
"dependencies": {
"@pedrofurtado/webpacker": "5.4.0-patched2"
}
}We here are using this fork (maintained by me until merge of this PR), while a new official 5.x release is not rolled out 馃 馃 |
|
@pedrofurtado i have already been using your branch, alas. I was hoping for something a bit more official... especially from this team :/ |
|
@guillaumebriday Are we ready for merge? 馃帀 |
Yarn v3 is released! Webpacker is already ready for this 馃帀