Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport for 5.x] Keep backups, even when they're old #2912

Merged
merged 1 commit into from Apr 27, 2021
Merged

[Backport for 5.x] Keep backups, even when they're old #2912

merged 1 commit into from Apr 27, 2021

Commits on Feb 4, 2021

  1. Keep backups, even when they're old. (#2734) 

    Recently, we encountered an issue with webpacker removing our previous assets
during the webpacker:clean task, and not keeping the specified number of
backups. We expected the [behavior from sprockets][sprockets], in which assets are
kept if under age or within the count limit. However, webpacker only keeps
assets if under age *AND* within the count limit.

I think this should work like sprockets and has perhaps been overlooked.

[sprockets]: https://github.com/rails/sprockets/blob/358f83ff09a77f69ac17543a9b1d127737060f00/lib/sprockets/manifest.rb#L258-L259

Backport-PR-URL: #2912
    @braddunbar @Pezmc
    braddunbar authored and Pezmc committed Feb 4, 2021
    Copy the full SHA
    80611e5 View commit details
    Browse the repository at this point in the history