[Backport for 5.x] Keep backups, even when they're old #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we encountered an issue with webpacker removing our previous assets during the webpacker:clean task, and not keeping the specified number of backups. We expected the [behavior from sprockets][sprockets], in which assets are kept if under age or within the count limit. However, webpacker only keeps assets if under age *AND* within the count limit. I think this should work like sprockets and has perhaps been overlooked. [sprockets]: https://github.com/rails/sprockets/blob/358f83ff09a77f69ac17543a9b1d127737060f00/lib/sprockets/manifest.rb#L258-L259 Backport-PR-URL: #2912
This was referenced Feb 4, 2021
|
@Pezmc you beat me to it! hahaha! I had cherry-picked this commit to my fork yesterday and was planning to send the PR today. Thanks! |
|
Hey, @Pezmc ! 👋 Thanks for backport this bugfix in 5.x branch 🤝 I think we are ready to merge @gauravtiwari ✅ PS: The failed builds in CI is not related to the PR code, and I opened a PR to fix that: #2903 |
|
@pedrofurtado @gauravtiwari How can I help get a release cut here? 6.0 is slated to be released soon which makes this backport semi-redundant, it'd be nice to benefit from it in the mean time and move my projects away from our custom fork of webpacker. |
Closed
|
released in 34c02ff thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is a backport for 5.x versions of #2734
It fixed an issue where webpacker would remove previous assets during clean, rather than keeping the specified number of backups and is currently only available in the 6.x beta.
Our rails projects are still currently using a custom fork of webpacker with this fix applied, but it seems many others have unearthed the same problem (#2443 (comment), Quimbee@624f687) backporting will fix up the issue for those yet to, or unable to, upgrade to 6.x.
/cc: @dkniffin @viniciusgama @braddunbar @oboxodo