Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF-DOCS] Active Record Callbacks #51654

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

[RF-DOCS] Active Record Callbacks #51654

wants to merge 55 commits into from

Commits on Mar 28, 2024

  1. base changes from the old PR

    @Ridhwana
    Ridhwana committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    82eff47 View commit details
    Browse the repository at this point in the history

  2. rename callback classes to callback objects

    @Ridhwana
    Ridhwana committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1b57299 View commit details
    Browse the repository at this point in the history

  3. remove instance var

    @Ridhwana
    Ridhwana committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7e93965 View commit details
    Browse the repository at this point in the history

  4. oxford comma

    @Ridhwana
    Ridhwana committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3afdb97 View commit details
    Browse the repository at this point in the history

  5. updates as per suggestions

    @Ridhwana
    Ridhwana committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    924f991 View commit details
    Browse the repository at this point in the history

  6. explain the use cases of callbacks

    @Ridhwana
    Ridhwana committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b1861ff View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. move the sentence below the code example

    @Ridhwana
    Ridhwana committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4f67b16 View commit details
    Browse the repository at this point in the history

  2. update the transactional callback ordering

    @Ridhwana
    Ridhwana committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d86f104 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. updates based on feedback

    @Ridhwana
    Ridhwana committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6009818 View commit details
    Browse the repository at this point in the history

  2. header guidelines

    @Ridhwana
    Ridhwana committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8f3fe46 View commit details
    Browse the repository at this point in the history

  3. column count

    @Ridhwana
    Ridhwana committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9854629 View commit details
    Browse the repository at this point in the history

  4. summary of the guide

    @Ridhwana
    Ridhwana committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7fb8b6a View commit details
    Browse the repository at this point in the history

  5. move callback objects to the end

    @Ridhwana
    Ridhwana committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2e1c5d8 View commit details
    Browse the repository at this point in the history

  6. collumn count

    @Ridhwana
    Ridhwana committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    482e198 View commit details
    Browse the repository at this point in the history

  7. make some small tweaks to the documentation

    @Ridhwana
    Ridhwana committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0c295cb View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9e7f924 View commit details
    Browse the repository at this point in the history

  2. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    fb86d3d View commit details
    Browse the repository at this point in the history

  3. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2d2d618 View commit details
    Browse the repository at this point in the history

  4. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    039fd2e View commit details
    Browse the repository at this point in the history

  5. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    91a2948 View commit details
    Browse the repository at this point in the history

  6. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    18c2bc3 View commit details
    Browse the repository at this point in the history

  7. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f7a2eee View commit details
    Browse the repository at this point in the history

  8. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2821627 View commit details
    Browse the repository at this point in the history

  9. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7308c8a View commit details
    Browse the repository at this point in the history

  10. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Petrik de Heus <petrik@deheus.net>
    @Ridhwana @p8
    Ridhwana and p8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    26a22f4 View commit details
    Browse the repository at this point in the history

  11. add before to relation

    @Ridhwana
    Ridhwana committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    3c12c32 View commit details
    Browse the repository at this point in the history

  12. replace puts with Rails.logger.info

    @Ridhwana
    Ridhwana committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7a3e44c View commit details
    Browse the repository at this point in the history

  13. change single quotes to double quotes

    @Ridhwana
    Ridhwana committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    cb1b471 View commit details
    Browse the repository at this point in the history

  14. change the method name to not include normalize

    @Ridhwana
    Ridhwana committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9501158 View commit details
    Browse the repository at this point in the history

  15. add a note about valid?

    @Ridhwana
    Ridhwana committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5dbbe0b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
    @Ridhwana @carlosantoniodasilva
    Ridhwana and carlosantoniodasilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    928df1e View commit details
    Browse the repository at this point in the history

  2. Update guides/source/active_record_callbacks.md 

    Co-authored-by: hatsu <hajiwata0308@gmail.com>
    @Ridhwana @hatsu38
    Ridhwana and hatsu38 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6272294 View commit details
    Browse the repository at this point in the history

  3. Update guides/source/active_record_callbacks.md 

    Co-authored-by: hatsu <hajiwata0308@gmail.com>
    @Ridhwana @hatsu38
    Ridhwana and hatsu38 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6f913ce View commit details
    Browse the repository at this point in the history

  4. Update guides/source/active_record_callbacks.md 

    Co-authored-by: hatsu <hajiwata0308@gmail.com>
    @Ridhwana @hatsu38
    Ridhwana and hatsu38 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8abf2c3 View commit details
    Browse the repository at this point in the history

  5. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
    @Ridhwana @carlosantoniodasilva
    Ridhwana and carlosantoniodasilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e595145 View commit details
    Browse the repository at this point in the history

  6. Update guides/source/active_record_callbacks.md 

    Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
    @Ridhwana @carlosantoniodasilva
    Ridhwana and carlosantoniodasilva committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9249abb View commit details
    Browse the repository at this point in the history

  7. make updates based on feedbcak

    @Ridhwana
    Ridhwana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    372df42 View commit details
    Browse the repository at this point in the history

  8. updates based on feeback

    @Ridhwana
    Ridhwana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7fd4890 View commit details
    Browse the repository at this point in the history

  9. updates based on feeback

    @Ridhwana
    Ridhwana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6d72caa View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into Ridhwana/active-record-callbacks-documentation

    @Ridhwana
    Ridhwana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    19ef855 View commit details
    Browse the repository at this point in the history

  11. lint

    @Ridhwana
    Ridhwana committed May 2, 2024
    Configuration menu
    Copy the full SHA
    42a53e1 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. fix the documentation on callback ordering

    @Ridhwana
    Ridhwana committed May 3, 2024
    Configuration menu
    Copy the full SHA
    32828b8 View commit details
    Browse the repository at this point in the history

  2. custome callbacks

    @Ridhwana
    Ridhwana committed May 3, 2024
    Configuration menu
    Copy the full SHA
    802c601 View commit details
    Browse the repository at this point in the history

  3. chore: format

    @Ridhwana
    Ridhwana committed May 3, 2024
    Configuration menu
    Copy the full SHA
    adcc289 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. add links

    @Ridhwana
    Ridhwana committed May 6, 2024
    Configuration menu
    Copy the full SHA
    cd7e6f6 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. skipping callbacks example

    @Ridhwana
    Ridhwana committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d9490a0 View commit details
    Browse the repository at this point in the history

  2. add some more information on custom contexts

    @Ridhwana
    Ridhwana committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4a254a2 View commit details
    Browse the repository at this point in the history

  3. suppress callbacks

    @Ridhwana
    Ridhwana committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7ab4995 View commit details
    Browse the repository at this point in the history

  4. rubocop fixes

    @Ridhwana
    Ridhwana committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a276e19 View commit details
    Browse the repository at this point in the history

  5. empty lines around code blocks

    @Ridhwana
    Ridhwana committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7dddb53 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. change the name of the class

    Ridhwana authored and Ridhwana committed May 15, 2024
    Configuration menu
    Copy the full SHA
    18f397d View commit details
    Browse the repository at this point in the history

  2. change the name of the class

    Ridhwana authored and Ridhwana committed May 15, 2024
    Configuration menu
    Copy the full SHA
    69b66b0 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'refs/remotes/origin/Ridhwana/active-rec… 

    …ord-callbacks-documentation' into Ridhwana/active-record-callbacks-documentation
    Ridhwana authored and Ridhwana committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2c1dcae View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'main' into Ridhwana/active-record-callbacks-documentation

    @Ridhwana
    Ridhwana committed May 16, 2024
    Configuration menu
    Copy the full SHA
    fbc8439 View commit details
    Browse the repository at this point in the history

  2. column wrap

    @Ridhwana
    Ridhwana committed May 16, 2024
    Configuration menu
    Copy the full SHA
    77b5e44 View commit details
    Browse the repository at this point in the history