New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RF-DOCS] Active Record Callbacks #51654
base: main
Are you sure you want to change the base?
[RF-DOCS] Active Record Callbacks #51654
Conversation
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
end | ||
``` | ||
|
||
```irb | ||
irb> @baby = Baby.create | ||
irb> baby = Baby.create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may be misunderstood, to test we need to interact with rails console instead irb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong, but didn't Rails update the irb prompt in newer versions? I'll double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice updates overall @Ridhwana , the guide flows much more naturally. I had a few bits of feedback/suggestions below.
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: hatsu <hajiwata0308@gmail.com>
Co-authored-by: hatsu <hajiwata0308@gmail.com>
Co-authored-by: hatsu <hajiwata0308@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Thanks, @carlosantoniodasilva, your feedback has been great as usual! I've updated the guides based on your feedback, and would appreciate if you could double-check these: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update!
Motivation / Background
This Pull Request has been created to provide more clarity and update the Active Record Callbacks documentation.
Detail
This guide has probably been reviewed multiple times over time, so we can do a quick pass to see where we can make things clearer, simpler, and/or more concise.
Some initial thoughts to get started:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]