Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken guide links #51573

Closed

Conversation

akhilgkrishnan
Copy link
Member

Detail

This Pull Request fixes the broken guide links in 7-0-stable.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@akhilgkrishnan akhilgkrishnan deleted the fix-broken-links branch April 15, 2024 17:49
@akhilgkrishnan akhilgkrishnan restored the fix-broken-links branch April 27, 2024 06:20
@rafaelfranca
Copy link
Member

Rails 7.0 doesn't receive bug fixes anymore. Thank you for the pull request

@akhilgkrishnan akhilgkrishnan deleted the fix-broken-links branch May 1, 2024 00:40
@zzak
Copy link
Member

zzak commented May 1, 2024

@akhilgkrishnan If you're interested in picking this up, #47654 was my attempt to add this to the guides:lint task.

That was before the mdl work was merged, so needs a rebase, but I think we could have two tasks: lint: [:mdl, :check_links] where the lint task just depends on both.

@akhilgkrishnan
Copy link
Member Author

@akhilgkrishnan If you're interested in picking this up, #47654 was my attempt to add this to the guides:lint task.

That was before the mdl work was merged, so needs a rebase, but I think we could have two tasks: lint: [:mdl, :check_links] where the lint task just depends on both.

@zzak Sure I'll work on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants