Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rake guides:lint task to raise error on broken anchor links #51702

Merged
merged 1 commit into from May 1, 2024

Conversation

akhilgkrishnan
Copy link
Member

This ticket is created based on the #51573 (comment), and its a follow-up for #47654.

Currently we have a rake task for linting the guides using the mdl.

Detail

This Pull Request adds the rake guides:lint:check_links task to verify any broken anchor links in the guides.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

cc/ @zzak

Co-authored-by: zzak <zzakscott@gmail.com>
@rails-bot rails-bot bot added the docs label May 1, 2024
@akhilgkrishnan akhilgkrishnan requested a review from zzak May 1, 2024 12:04
@rafaelfranca rafaelfranca merged commit 549144b into rails:main May 1, 2024
3 of 4 checks passed
@zzak
Copy link
Member

zzak commented May 1, 2024

Thanks Akhil!

@akhilgkrishnan akhilgkrishnan deleted the fix-guides-broken-link branch May 2, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants