Enable Lint/DuplicateMagicComment cop
#46497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables `Lint/DuplicateMagicComment` cop to resolve the background of rubocop/rubocop#11043. And this PR bumps RuboCop version because the cop was introduced in RuboCop 1.37.0: https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#1370-2022-10-20
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Nov 15, 2022
Follow up rails/rails#46497. This PR enables `Lint/DuplicateMagicComment` cop and requires RuboCop 1.39+.
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Nov 15, 2022
Follow up rails/rails#46497. This PR enables `Lint/DuplicateMagicComment` cop and requires RuboCop 1.39+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This PR enables
Lint/DuplicateMagicCommentcop to resolve the background of rubocop/rubocop#11043.Detail
And this PR bumps RuboCop version because the cop was introduced in RuboCop 1.37.0: https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#1370-2022-10-20
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]