Skip to content

Commit

Permalink
Enable Lint/DuplicateMagicComment cop
Browse files Browse the repository at this point in the history
Follow up rails/rails#46497.

This PR enables `Lint/DuplicateMagicComment` cop and requires RuboCop 1.39+.
  • Loading branch information
koic committed Nov 15, 2022
1 parent 027c06b commit 277086f
Show file tree
Hide file tree
Showing 11 changed files with 6 additions and 101 deletions.
2 changes: 1 addition & 1 deletion Appraisals
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

SUPPORTED_VERSIONS = %w[1.29 1.30 1.31 1.32 1.33 1.34 1.35 1.36].freeze
SUPPORTED_VERSIONS = %w[1.39].freeze

SUPPORTED_VERSIONS.each do |version|
appraise "rubocop-#{version}" do
Expand Down
3 changes: 3 additions & 0 deletions config/rails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ Lint/AmbiguousRegexpLiteral:
Lint/DuplicateRequire:
Enabled: true

Lint/DuplicateMagicComment:
Enabled: true

Lint/DuplicateMethods:
Enabled: true

Expand Down
14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.30.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.31.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.32.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.33.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.34.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.35.gemfile

This file was deleted.

14 changes: 0 additions & 14 deletions gemfiles/rubocop_1.36.gemfile

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ gem "bundler"
gem "minitest"
gem "rake"
gem "rails", ">= 5.2"
gem "rubocop", "~> 1.29.0"
gem "rubocop", "~> 1.39.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion rubocop-rails_config.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
spec.license = "MIT"
spec.required_ruby_version = ">= 2.6.0"

spec.add_dependency "rubocop", ">= 1.29.0"
spec.add_dependency "rubocop", ">= 1.39.0"
spec.add_dependency "rubocop-ast", ">= 1.0.1"
spec.add_dependency "rubocop-minitest", "~> 0.22"
spec.add_dependency "rubocop-performance", "~> 1.11"
Expand Down

0 comments on commit 277086f

Please sign in to comment.