Fix flaky test in HasManyThroughDisableJoinsAssociationsTest #43649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on #38957 I got the HasManyThroughDisableJoinsAssociationsTest#test_to_a_on_disable_joins_with_multiple_scopes sometimes failing in PSQL suite, which's weird since I do not even touch AR:
PostgreSQL does not guarantee the order of records and we never specify it. I wonder if adding an explicit order is fine or it makes the spec itself wrong.