Merge pull request #43649 from DmitryTsepelev/flaky-spec-for-associat…

…ions Fix flaky test in HasManyThroughDisableJoinsAssociationsTest
rails · Nov 15, 2021 · 1c2468f · 1c2468f
2 parents 32228ff + 5d212a5
commit 1c2468f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/activerecord/test/models/author.rb b/activerecord/test/models/author.rb
@@ -53,13 +53,13 @@ def ratings
 
   has_many :ratings, through: :comments
   has_many :good_ratings,
-    -> { where("ratings.value > 5") },
+    -> { where("ratings.value > 5").order(:id) },
     through: :comments,
     source: :ratings
 
   has_many :no_joins_ratings, through: :no_joins_comments, disable_joins: :true, source: :ratings
   has_many :no_joins_good_ratings,
-    -> { where("ratings.value > 5") },
+    -> { where("ratings.value > 5").order(:id) },
     through: :comments,
     source: :ratings,
     disable_joins: true