Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webdriver 4.6.1 or higher to support selenium-webdriver 4.0.0 #43456

Merged
merged 1 commit into from Oct 14, 2021

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Oct 14, 2021

Summary

This pull request forces bundler to use webdriver 4.6.1 or higher to workaround #43455 until titusfortner/webdrivers#218 is merged and released.

Fix #43455
Related to titusfortner/webdrivers#218

This pull request forces bundler to use webdriver 4.6.1 or higher
to workaround rails#43455 until titusfortner/webdrivers#218 is merged and
released.

Fix rails#43455
titusfortner/webdrivers#218
@yahonda
Copy link
Member Author

yahonda commented Oct 14, 2021

Let me take a look at Active Support failures.
https://buildkite.com/rails/rails/builds/81799#5bb8f77b-0899-4908-992b-cbd785ec818d/1091-1102

@yahonda
Copy link
Member Author

yahonda commented Oct 14, 2021

Active Support failures are not relevant to this pull request, it is triggered by dalli version changes from 2.7.11 to 3.0.1. Opened a issue #43457

@kamipo kamipo merged commit 23622fb into rails:main Oct 14, 2021
yahonda added a commit to yahonda/rails that referenced this pull request Oct 14, 2021
@yahonda yahonda deleted the force_to_use_webdriver_4_or_higher branch January 2, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action View test:ujs fails due to lower version of webdrivers (2.4.0) is chosen
2 participants