Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to specify webdrivers version to support selenium-webdriver 4 #43468

Merged
merged 1 commit into from Oct 15, 2021

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Oct 14, 2021

Summary

webdrivers 4.7.0 has been released including titusfortner/webdrivers#218 which supports selenium-webdriver 4.0.0

Refer
https://github.com/titusfortner/webdrivers/blob/main/CHANGELOG.md#470-2021-10-14
Related to #43456

@kamipo kamipo merged commit dcae128 into rails:main Oct 15, 2021
@morgoth
Copy link
Member

morgoth commented Oct 19, 2021

After upgrading to selenium-webdriver 4.0.0 I'm getting a warning:

2020-06-10 08:00:00 WARN Selenium [DEPRECATION] [:browser_options] :options as a parameter for driver initialization is deprecated. Use :capabilities with an Array of value capabilities/options if necessary instead.

when running system tests.

I'm not yet sure who is triggering this warning but I guess it's rails

@yahonda
Copy link
Member Author

yahonda commented Oct 19, 2021

There was a pull request to address the warning in CI.
https://github.com/rails/rails/pull/43459/files , which is for CI then may not for "system tests".

How about runninggit grep '::Selenium::WebDriver' in the Rails repository and finding the code which raises this warning?

@yahonda
Copy link
Member Author

yahonda commented Oct 20, 2021

#43493 may be related.

@yahonda yahonda deleted the webdrivers_470 branch January 2, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants