Enable Style/ExplicitBlockArgument cop
#314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is disabled by default because in some cases it could change the block arity which might fail if the block is actualy a lambda. However I enabled it on Rails and shopify-core and it went just fine. Since this cop is beneficial for production performance and for triming CI backtraces a bit, I think we should enable it.
casperisfine
force-pushed
the
explicit-block-argument
branch
from
ef0a36f
to
61a6451
Compare
sambostock
approved these changes
Sep 7, 2021
rafaelfranca
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is disabled by default because in some cases it could change the block arity which might fail if the block is
actually a lambda.
However I enabled it on Rails and shopify-core and it went just fine.
Since this cop is beneficial for production performance and for trimming CI backtraces a bit, I think we should enable it.