Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid schema dump when primary key column has a comment #36384

Merged
merged 1 commit into from Jun 3, 2019
Merged

Fix invalid schema dump when primary key column has a comment #36384

merged 1 commit into from Jun 3, 2019

Commits on Jun 3, 2019

  1. Fix invalid schema dump when primary key column has a comment 

    Before this fix it would either generate an invalid schema, passing `comment` option twice to `create_table`, or it move the comment from primary key column to the table if table had no comment when the dump was generated.

The situation now is that a comment on primary key will be ignored (not present on schema).

Fixes rails#29966
    @guigs
    guigs committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    49f3104 View commit details
    Browse the repository at this point in the history