Fix invalid schema dump when primary key column has a comment #36384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix it would either generate an invalid schema, passing `comment` option twice to `create_table`, or it move the comment from primary key column to the table if table had no comment when the dump was generated. The situation now is that a comment on primary key will be ignored (not present on schema). Fixes rails#29966
guigs
force-pushed
the
fix-invalid-schema-when-pk-column-has-comment
branch
from
5ebb9ef
to
49f3104
Compare
kamipo
added a commit
that referenced
this pull request
Jun 3, 2019
…n-has-comment Fix invalid schema dump when primary key column has a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix it would either generate an invalid schema, passing
commentoption twice tocreate_table, or it move the comment from primary key column to the table if table had no comment when the dump was generated.The situation now is that a comment on primary key will be ignored (not present on schema). I've submitted a proposal to fix this on #36385.
Fixes #29966