Fix table comment also being applied to the primary key column #36373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
added a commit
that referenced
this pull request
Jun 2, 2019
…lied-to-the-primary-key-column Fix table comment also being applied to the primary key column
kamipo
added a commit
that referenced
this pull request
Jun 2, 2019
`create_table` and `t.column` have the same named options (e.g. `:comment`, `:primary_key`), so it should be separated table options from column options. Related #36373.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While investigating #29966 I found this related bug that a table created with a comment in a
create_tablecall like thisWill also add the same comment to the primary key column in the database.
Detailed analysis
I traced back the origin of this bug. In the initial PR that added the database comments support, the comment option on the create table was not being passed to the primary key options, as can be seen here.
But then, after these 2 subsequent refactors 485e7f2 and b04c633, the comment option was not being excluded from primary key options anymore and thus the bug.