Raise StrictLoadingViolationError with polymorphic relation violations #45016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
reviewed
May 4, 2022
|
That was an oversight on my part, thanks @eileencodes ! ❤️ |
Performing strict_loading! on a model with a polymorphic association currently raises an ArgumentError because it attempts to look up the klass on the polymorphic association, which is not possible. The error message for StrictLoadingViolationError on models with polymorphic relationships should omit the klass for the association.
adrianna-chang-shopify
force-pushed
the
ac-fix-strict-loading-polymorphic-associations
branch
from
66c038d
to
71828a4
Compare
eileencodes
added a commit
that referenced
this pull request
May 5, 2022
…oading-polymorphic-associations Raise StrictLoadingViolationError with polymorphic relation violations
|
Backported to 7-0-stable in cd7700b |
adrianna-chang-shopify
deleted the
ac-fix-strict-loading-polymorphic-associations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #44906
Performing
strict_loading!on a model with a polymorphic association currently raises anArgumentErrorbecause it attempts to look up the klass for the association, which is not possible. The error message forStrictLoadingViolationErroron models with polymorphic relationships should omit the klass for the association.