Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise StrictLoadingViolationError with polymorphic relation violations #45016

Merged
merged 1 commit into from May 5, 2022
Merged

Raise StrictLoadingViolationError with polymorphic relation violations #45016

merged 1 commit into from May 5, 2022

Commits on May 5, 2022

  1. Raise StrictLoadingViolationError with polymorphic relation violations 

    Performing strict_loading! on a model with a polymorphic association
currently raises an ArgumentError because it attempts to look up the
klass on the polymorphic association, which is not possible. The error
message for StrictLoadingViolationError on models with polymorphic
relationships should omit the klass for the association.
    @adrianna-chang-shopify
    adrianna-chang-shopify committed May 5, 2022
    Copy the full SHA
    71828a4 View commit details
    Browse the repository at this point in the history