forked from rails/rails
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activestorage debug #1
Open
miquelbarba
wants to merge
474
commits into
main
Choose a base branch
from
activestorage_debug
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Document that @rails/ujs is deprecated for `button_to` This was missed in rails#43112 * deprecation needs to go below the examples
…ion-note Adds webpacker retired note to the webpacker guide [ci skip]
…e_update_checker-gc-test Fix flakey EventedFileUpdateChecker GC test
Improve upgrade instructions for Bootsnap [ci-skip] (cherry picked from commit 65e4e4e)
…e-core-ext-require Fix missing require of reverse_merge extension
…ciated Improve associated with no reflection error
fix que integration in Active Job tests
After rails#43859, the constants were being registered to be eagear loaded but the eager load was not being called on it, so they were still being required at runtime.
Use released version of pg 1.3
fix que integration in Active Job tests part 2
fix Que integration tests for Active Job
Fixes a typo in the ActiveRecord encryption documentation [ci-skip]
…defined-by-record-association Fix error when saving an association with a relation named record
…ery-batch abandon_results! after every multi statement batch
Address ActionView::Template::Error at CI
…ault update default active storage processor [ci skip] (cherry picked from commit 77131ea)
Decoration is normally a use case for applications. Therefore we only need the example for zeitwerk mode nowadays.
Add turbolinks=false on links to older guides
…lumn Fix parsing expression for PostgreSQL generated column
Dump the database schema containing the current Rails version
…pted-fields-hook-twice Setup on_encrypted_attribute_declared hook only once
Dump the precision for datetime columns following the new defaults
Add missing info for `change` column and table comment in Guides [ci-skip] (cherry picked from commit bc9fa03)
…ite-of-cookie Add API doc for the `same_site` option of the `cookie` [ci-skip] (cherry picked from commit 29daa0b)
…unnamed-binds activerecord: Backport sql log for unnamed binds fix
…nto_place_in_7_0_release_notes__ci_skip_ Put Active Record changes into place in 7.0 release notes [ci-skip]
Simplify regex detecting comments in sql query
Update RDoc comments for #redirect [ci-skip] (cherry picked from commit 625126a)
Clarify to users what objects may be cached, and highlight the option used to cache default non-serializable data. Purpose: Improving new-to-Rails users' experience, as this detail may not be obvious, costing them time and effort spent debugging. Co-authored-by: Hartley McGuire <skipkayhil@gmail.com> Co-authored-by: Jonathan Hefner <jonathan@hefner.pro> (cherry picked from commit de12c18)
Document `uses_transaction` [ci-skip] (cherry picked from commit 74cd04d)
Document action mailer rescue_from [ci-skip] (cherry picked from commit e4ec2cb)
…d-querying Doc: fix of name attribute [ci-skip] (cherry picked from commit 8bc187d)
Fix disabling strict_loading when enabled by default
…ict-loading-polymorphic-associations Raise StrictLoadingViolationError with polymorphic relation violations
Fix tag helper regression
Fix link to Thor's docs [ci-skip] (cherry picked from commit 8dce413)
These tests were copied over from `main` in a1fbc46, however this feature is only present in `main` which was causing the tests on 7-0-stable to fail.
In Psych >= 4.0.0, load defaults to safe_load. This commit makes the ActiveRecord::Coders::YAMLColum class use Psych safe_load as the Rails default. This default is configurable via ActiveRecord.use_yaml_unsafe_load We conditionally fallback to the correct unsafe load if use_yaml_unsafe_load is set to true. unsafe_load was introduced in Psych 4.0.0 The list of safe_load permitted classes is configurable via ActiveRecord.yaml_column_permitted_classes [CVE-2022-32224]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveRecord::Base#remove_connection
ActiveRecord::Connection#allowed_index_name_length
ActiveRecord::Connection#:in_clause_length
ActiveRecord::DatabaseConfigurations::DatabaseConfig#spec_name
config
indbconsole
ActiveSupport::Testing::Deprecation
rails/rails#43774 from sambostock/document-deprecation-test-helpersto_s(format)
in favor ofto_formatted_s(format)
rails/rails#43772 from rails/rm-deprecate-to_s#to_s
deprecation.Pathname#existence
[ci-skip]PathnameExistenceTest
rails/rails#43786 from rmacklin/fix-typo-in-PathnameExistenceTestActionController::TestCase
: reset instance variables after each request rails/rails#43735 from ghiculescu/as-testcase-ivarsfield_id
in terms of the FormBuilder'snamespace:
option rails/rails#43408 from seanpdoyle/action-view-form-builder-field-id-optionsrails new
using specified prerelease version rails/rails#39663 from jonathanhefner/rails-new-prereleasebutton_to
helper changes in Rails 7.0 rails/rails#43855 from nvasilevski/button-to-changes-to-release-notesindex.html.erb
variable name rails/rails#43880 from jonathanhefner/fix-scaffold-index_html_erb-variable-namePreloaderTest
rails/rails#43873 from yahonda/fix43872[id]
forFormBuilder#button
called with method name rails/rails#43886 from seanpdoyle/form-builder-button-method-name-idload_async
ActionController::Parameters
with@logging_context
rails/rails#43900 from yykamei/initialize-with-logging_contextadd_foreign_key
[ci-skip] rails/rails#43811 from eikes/migrations-guide-foreign-key-deferrableQueryMethods#in_order_of
to handle empty order list rails/rails#43916 from Shopify/activerecord-in-order-of-empty-arraylink_to
with a model passed as an argument twice rails/rails#43918 from ghiculescu/link-to-model-twicelink_to
with a model passed as an argument twice rails/rails#43918Class#subclasses
existing withoutClass#descendants
Enumerable#sum
andArray#sum
Enumerable#sum
andArray#sum
"digest
3.1.0 as standard library rails/rails#43999 from yahonda/digest310_ruby310config.active_record.partial_inserts
in guide [skip ci]on update CURRENT_TIMESTAMP
for mysql2 adapter rails/rails#44040 from kmasuda-aiming/extract-on-update-current-timestampcookies_serializer
config default rails/rails#44067 from ghiculescu/patch-7pg_dump
in the Postgres test suite rails/rails#44069 from ghiculescu/postgres-test-dumpActiveRecord::Enum
support rails/rails#44055 from ghiculescu/postgres-guide-enumconfig.active_storage.video_preview_arguments
description. [skip ci] rails/rails#44060 from soartec-lab/fix/doc-video_preview_arguments-default-valueoff
for helpers that build hidden type input tags. [skip ci] rails/rails#43994 from soartec-lab/fix/hidden-helpers-documentActiveRecord::QueryMethods::WhereChain#missing
rails/rails#44000 from ykpythemind/better_message_for_missingpg
gem 1.3.0.rc1 or higher for Ruby 3.2.0dev rails/rails#44007 from yahonda/ruby32_pgdiscard_on/retry_on ActiveJob::DeserializationError
rails/rails#43066QueryMethods#in_order_of
drop records not listed rails/rails#44097 from kddnewton/in-order-of-filterbutton_to
(Document that @rails/ujs is deprecated forbutton_to
rails/rails#44100)body#close
bigdecimal
require inActiveJob::Arguments
session_store
configuration instructions [ci-skip] rails/rails#44423 from jonathanhefner/guides-update-session_store-instructionsfields_for
helper sections [ci-skip] rails/rails#44420 from jonathanhefner/guide-form_helpers-fields_for-fields_fortrailing_slash: true
in route definitionform_for
: Attempt to callto_model
on first argument rails/rails#44328 from seanpdoyle/form-for-to-model.gitattributes
file in Getting Started documentation [ci-skip] rails/rails#44486 from ghousemohamed/patch-7BooksController
in Rails guide [ci-skip] rails/rails#44522 from ghousemohamed/patch-11serialize
API doc [ci-skip] rails/rails#44507 from jonathanhefner/apidocs-improve-active_record-serialize-docFile::NULL
instead of/dev/null
rails/rails#44543 from jonathanhefner/postgres-structure_load-dev_null-to-file_nullchange_column_comment
to preserve column's AUTO_INCREMENT in the MySQL adapter rails/rails#44480 from fatkodima/change_column_comment-auto_incrementassert_queries
& al rails/rails#44484 from rails/sql-assertions:nodoc:
toActiveRecord::Relation#where_values_hash
rails/rails#44481 from Cofense/active-record-relation-where_values_hash-nodoc--no-comments
from Postgres structure dump command rails/rails#44633 from ghiculescu/revert-43216remove_foreign_key
with:if_exists
option when foreign key actually exists rails/rails#44637 from fatkodima/remove_foreign_key-if_existsraise_on_open_redirects
is enabled rails/rails#44650 from tomhughes/relative-redirectcontroller_class_path
inRails::Generators::NamedBase#route_url
rails/rails#44670 from pixeltrix/fix-generator-route-url-for-namespaced-controllers#version
method docs and some typos [ci-skip] rails/rails#44693 from ghousemohamed/fix-docs-related-gem-versionsMySQL::SchemaStatements#create_table_sql
rails/rails#44712 from Shopify/fix-mysql-show-create-tableRange#overlaps?
for beginless ranges rails/rails#44757 from donny741/fix-overlaps-for-beginless-rangedb:prepare
task to create/migrate test db when dev db already exists rails/rails#44820 from fatkodima/db_prepare-dev-existssecret_key_base
in cookie rotator example rails/rails#44862 from jackscotti/patch-1data-remote
anddata-method
are deprecated rails/rails#44784 from ghiculescu/data-remote-no-turboactiverecord
locale namespace in example in guides [ci-skip] rails/rails#44865 from entretechno/guides-locale-errorsrun_load_hooks
[ci-skip] rails/rails#44893 from ghousemohamed/add-docs-for-run-load-hooksdb:prepare
to run seeds once rails/rails#44958 from fatkodima/fix-db_prepare-seedschange
column and table comment in Guides rails/rails#44928 from gumatias/patch-1same_site
option of thecookie
[skip ci] rails/rails#44934 from soartec-lab/add-api-doc-for-samesite-of-cookieaction_controller/metal/exceptions
toaction_controller
uses_transaction
[ci-skip] rails/rails#44956 from sato11/document-uses_transaction