Fix strict loading on validations #40775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want strict loading to throw an error on validations since those need to load the record in order to validate it. This change check the owners's `validation_context`. If it's `nil` then we know we're not currently validating an object in create/update. If it's set then we're validating and want to skip raising for strict loading. Fixes: rails#40767
rafaelfranca
approved these changes
Dec 9, 2020
rafaelfranca
pushed a commit
that referenced
this pull request
Dec 9, 2020
…dations Fix strict loading on validations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want strict loading to throw an error on validations since
those need to load the record in order to validate it.
This change check the owners's
validation_context. If it'snilthenwe know we're not currently validating an object in create/update. If
it's set then we're validating and want to skip raising for strict
loading.
Fixes: #40767