Disable strict loading on ActiveStorage::Attached::Changes #41461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we try to attach a new file with
strict_loading_by_default = true
on the model, will always raise an ActiveRecord::StrictLoadingViolationError because of validation of active storage (https://github.com/rails/rails/blob/main/activestorage/lib/active_storage/attached/changes/create_one.rb#L43).This validation is trigger always without loading any association (https://github.com/rails/rails/blob/main/activestorage/lib/active_storage/attached/model.rb#L65)
In past, we already disable strict_loading on validations(#40775), but active_storage still keeps this validation. This PR disable strict_loading on save of
Attached::Changes::CreateOne
This PR solves the issue: #41453
Setup