Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strict loading on validations #40775

Merged
merged 1 commit into from Dec 9, 2020
Merged

Fix strict loading on validations #40775

merged 1 commit into from Dec 9, 2020

Commits on Dec 9, 2020

  1. Fix strict loading on validations 

    We don't want strict loading to throw an error on validations since
those need to load the record in order to validate it.

This change check the owners's `validation_context`. If it's `nil` then
we know we're not currently validating an object in create/update. If
it's set then we're validating and want to skip raising for strict
loading.

Fixes: rails#40767
    @eileencodes
    eileencodes committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    bda9bc0 View commit details
    Browse the repository at this point in the history