dep: update loofah and nokogiri to versions fully supporting HTML5 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
approved these changes
May 23, 2023
- loofah v2.21.x introduced Rails::HTML5::Sanitizer
- nokogiri v1.14.x is needed for loofah to subclass Nokogiri::HTML5::{Document,DocumentFragment}
Update required_ruby_version to ">= 2.7.0" to match Nokogiri's
constraint for v1.14.x.
Update CI to only test supported Ruby versions.
flavorjones
force-pushed
the
flavorjones-update-deps-for-html5-variation2
branch
from
03ed4e7
to
7cc07bb
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS VARIATION 2 - see variation 1 at #164
Require versions of Nokogiri and Loofah that support HTML5:
Update required_ruby_version to ">= 2.7.0" to match Nokogiri's constraint for v1.14.x.
Update CI to only test supported Ruby versions.
The alternative (#164) is to continue to support older versions of Nokogiri (for Ruby 2.5) and Loofah.