dep: support older versions of Nokogiri and Loofah #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-update-deps-for-html5
branch
from
bef0c49
to
d5ac27e
Compare
and add a test to assert what the README says about whether Rails::HTML5::Sanitizer is defined.
to maintain backwards compatibility for a while longer
to maintain backwards compatibility with older version of Loofah
flavorjones
force-pushed
the
flavorjones-update-deps-for-html5
branch
from
2b1890f
to
d2cbae7
Compare
flavorjones
changed the title
|
Closing in favor of #166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS VARIATION 1 - see variation 2 at #166
If we want to support Rails 6.1+ (and Ruby 2.5) we need to do this. The alternative (#166) is to pin to newer versions and only support Rails 7.0+ (Ruby 2.7).
Update CI to run with pre-HTML5 versions of Nokogiri and Loofah on Ruby 2.5.