Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convenient cache and content type for response generation #944

Closed
wants to merge 4 commits into from
Closed

Convenient cache and content type for response generation #944

wants to merge 4 commits into from

Commits on Jan 25, 2016

  1. Convenient cache and content type for response generation 

    These three convenient methods make it easy to declaratively specify how a response should be structured. For example:

    response.do_not_cache!

    response.cache!

    response.content_type! 'text/html'

Open to discussion w.r.t. naming, and behaviour. I monkey patch these in which might be fine for my usage, but I thought it could be useful to a wider audience.
    @ioquatix
    ioquatix committed Jan 25, 2016
    Configuration menu
    Copy the full SHA
    0f75385 View commit details
    Browse the repository at this point in the history

  2. Basic specs to cover cache!, do_not_cache! and content_type!

    @ioquatix
    ioquatix committed Jan 25, 2016
    Configuration menu
    Copy the full SHA
    ed05994 View commit details
    Browse the repository at this point in the history

  3. Remove content_type! setter.

    @ioquatix
    ioquatix committed Jan 25, 2016
    Configuration menu
    Copy the full SHA
    3da1b4b View commit details
    Browse the repository at this point in the history

  4. Add content_type method similar to etag and cache_control.

    @ioquatix
    ioquatix committed Jan 25, 2016
    Configuration menu
    Copy the full SHA
    66408c7 View commit details
    Browse the repository at this point in the history