Convenient cache and content type for response generation #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
patch-2
branch
2 times, most recently
from
cea4931
to
9190409
Compare
These three convenient methods make it easy to declaratively specify how a response should be structured. For example:
response.do_not_cache!
response.cache!
response.content_type! 'text/html'
Open to discussion w.r.t. naming, and behaviour. I monkey patch these in which might be fine for my usage, but I thought it could be useful to a wider audience.
|
I have rebased this, is it possible to get some feedback? Thanks :) |
|
These changes look good to me. They do not appear to affect backwards compatibility, so I would think we could add them in 2.2 (if that is coming before 3.0). @ioquatix can you rebase against master? |
|
Ok :) |
|
Closing in favour of #1555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three convenient methods make it easy to declaratively specify how a response should be structured. For example:
Open to discussion w.r.t. naming, and behaviour. I monkey patch these in which might be fine for my usage, but I thought it could be useful to a wider audience.