Make query parameters without = have empty string values #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reverted in 77cf057 so that Rails could have historical Rack behavior without the complexity of splitting form/query parsing. Now that splitting form/query parsing has been added back in 3855d1d, this changes the behavior to what originally shipped in Rack 3. This matches URL spec section 5.1.3.3. Frameworks that want Rack's historical behavior of using nil values instead of empty string values can reparse QUERY_STRING and use rack.request.form_pairs to get the behavior they want.
|
Is this going to ship with Rack 3.1? |
|
I suggest we consider this for Rack 3.2+ or 4.0. Maybe we can introduce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reverted in 77cf057 so that Rails could have historical Rack behavior without the complexity of splitting form/query parsing.
Now that splitting form/query parsing has been added back in 3855d1d, this changes the behavior to what originally shipped in Rack 3.
This matches URL spec section 5.1.3.3. Frameworks that want Rack's historical behavior of using nil values instead of empty string values can reparse QUERY_STRING and use rack.request.form_pairs to get the behavior they want.