Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rack.response_finished to Rack::Lint #1802
Add rack.response_finished to Rack::Lint #1802
Changes from 3 commits
0cc589a
0a2c349
20da7c3
32d4b96
db15309
8f343bd
d54a3cf
57aaaac
56b3ae8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BlakeWilliams @tenderlove looking at other keys, should this be
rack.response.finished
orrack.response_finished
? We don't userack.request_form_input
butrack.request.form_input
.Is there any precedent for appending
_callbacks
to the name i.e.rack.response.finished_callbacks
or something? I don't mind either way, just calling it out for further discussion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of it being "namespaced", like
rack.response.finished
. I'll update that real quick, but I also like the idea of specifying that it is some kind of array of callbacks. I'll defer to other folks on naming, but I'm 👍 onrack.response.finished_callbacks
.