Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rack.response_finished to Rack::Lint #1802

Closed
wants to merge 9 commits into from
Closed

Add rack.response_finished to Rack::Lint #1802

wants to merge 9 commits into from

Commits on Apr 5, 2022

  1. Add rack.response_finished to Rack::Lint 

    This updates Rack::Lint to validate that `rack.response_finished` is an
array of callables when present in the `env`. e.g. procs, lambdas, or
objects that respond to `call`.

This validates that:

* `rack.response_finished` is an array
* The contents of the array all respond to `call`
    @BlakeWilliams
    BlakeWilliams committed Apr 5, 2022
    Copy the full SHA
    0cc589a View commit details
    Browse the repository at this point in the history

  2. Fix test error due to casing

    @BlakeWilliams
    BlakeWilliams committed Apr 5, 2022
    Copy the full SHA
    0a2c349 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Add more details to spec

    @BlakeWilliams
    BlakeWilliams committed Apr 8, 2022
    Copy the full SHA
    20da7c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Update SPEC.rdoc 

    Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
    @BlakeWilliams @ioquatix
    BlakeWilliams and ioquatix committed Apr 11, 2022
    Copy the full SHA
    32d4b96 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Pass env, support objects that respond to #call

    @BlakeWilliams
    BlakeWilliams committed Jun 28, 2022
    Copy the full SHA
    db15309 View commit details
    Browse the repository at this point in the history

  2. Update spec description

    @BlakeWilliams
    BlakeWilliams committed Jun 28, 2022
    Copy the full SHA
    8f343bd View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. rack.response_finished -> rack.response.finished

    @BlakeWilliams
    BlakeWilliams committed Jul 11, 2022
    Copy the full SHA
    d54a3cf View commit details
    Browse the repository at this point in the history

  2. Spec docs

    @BlakeWilliams
    BlakeWilliams committed Jul 11, 2022
    Copy the full SHA
    57aaaac View commit details
    Browse the repository at this point in the history

  3. Remove extra newline

    @BlakeWilliams
    BlakeWilliams committed Jul 11, 2022
    Copy the full SHA
    56b3ae8 View commit details
    Browse the repository at this point in the history