Add CHANGELOG entry for #1034

Also changed the error messagen and the implementation to use `#fetch`.
rack · Sep 27, 2018 · 5559676 · 5559676
1 parent b40583b
commit 5559676
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file. For info on
 - CHANGELOG.md using keep a changelog formatting by @twitnithegirl
 
 ### Changed
+- `Rack::Utils.status_code` now raises an error when the status symbol is invalid instead of `500`.
 
 ### Removed
 - HISTORY.md by @twitnithegirl

diff --git a/lib/rack/utils.rb b/lib/rack/utils.rb
@@ -563,8 +563,7 @@ def names
 
     def status_code(status)
       if status.is_a?(Symbol)
-        raise ArgumentError, "Unrecognized status_code symbol" unless SYMBOL_TO_STATUS_CODE[status]
-        SYMBOL_TO_STATUS_CODE[status]
+        SYMBOL_TO_STATUS_CODE.fetch(status) { raise ArgumentError, "Unrecognized status code #{status.inspect}" }
       else
         status.to_i
       end

diff --git a/test/spec_utils.rb b/test/spec_utils.rb
@@ -463,7 +463,7 @@ def initialize(*)
   end
 
   it "raise an error for an invalid symbol" do
-    assert_raises(ArgumentError, "Unrecognized status_code symbol") do
+    assert_raises(ArgumentError, "Unrecognized status code :foobar") do
       Rack::Utils.status_code(:foobar)
     end
   end