Merge pull request #1034 from adambutler/bugfix/response-status-defau…

…lt=to-raise-exception When a symbol is passed as a status code it must match a valid http status code.
rack · Sep 27, 2018 · b40583b · b40583b
2 parents 2a74e81 + e6bdee4
commit b40583b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/rack/utils.rb b/lib/rack/utils.rb
@@ -563,7 +563,8 @@ def names
 
     def status_code(status)
       if status.is_a?(Symbol)
-        SYMBOL_TO_STATUS_CODE[status] || 500
+        raise ArgumentError, "Unrecognized status_code symbol" unless SYMBOL_TO_STATUS_CODE[status]
+        SYMBOL_TO_STATUS_CODE[status]
       else
         status.to_i
       end

diff --git a/test/spec_utils.rb b/test/spec_utils.rb
@@ -462,6 +462,12 @@ def initialize(*)
     Rack::Utils.status_code(:ok).must_equal 200
   end
 
+  it "raise an error for an invalid symbol" do
+    assert_raises(ArgumentError, "Unrecognized status_code symbol") do
+      Rack::Utils.status_code(:foobar)
+    end
+  end
+
   it "return rfc2822 format from rfc2822 helper" do
     Rack::Utils.rfc2822(Time.at(0).gmtime).must_equal "Thu, 01 Jan 1970 00:00:00 -0000"
   end