Core: correct flat module.only usage by marking currentModule as ignored #1658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1645.
The first time we process a
module.only
call, we chop the list of tests that have accumulated so far, and then mark everything after that as an early-return to not even process it. But there's the edge-case where we're currently within a nested module, which might add more tests as "siblings" to that module.only usage. By forcefully marking thecurrentTest
asignored
, we are sure to accurately filter other trailing cases.Added a unittest by squeezing in a new test case to a prior test for
module.only
. That is admittedly growing in complexity, but I think still serves as a great integration-level test to really stress the combinations.